Ajout de test supplémentaires pour SuccessController
continuous-integration/drone/push Build is passing Details

notePad
Maxime SAPOUNTZIS 1 year ago
parent 3efa6816fe
commit 493719d1db

@ -1,6 +1,7 @@
using API.Controllers; using API.Controllers;
using Dto; using Dto;
using Microsoft.AspNetCore.Mvc; using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.Routing;
using Microsoft.Extensions.Logging.Abstractions; using Microsoft.Extensions.Logging.Abstractions;
using Moq; using Moq;
using Shared; using Shared;
@ -40,14 +41,30 @@ public class SuccessesUnitTest
} }
[Fact] [Fact]
public void GetSuccessesListFail() public void GetSuccessesListFail_When_Result_Equal_0()
{ {
_successService.Setup(x => x.GetSuccesses(1, 4, 0)) _successService.Setup(x => x.GetSuccesses(1, 4, 0))
.Returns(new List<SuccessDto>()); .Returns(new List<SuccessDto>());
var successesController = var successesController =
new SuccessesController(_successService.Object, new NullLogger<SuccessesController>()); new SuccessesController(_successService.Object, new NullLogger<SuccessesController>());
var successesResult = successesController.GetSuccesses(2, 3, 0); var successesResult = successesController.GetSuccesses(26373, 31771, 0);
if (successesResult is StatusCodeResult statusCodeResult && statusCodeResult.StatusCode == 204)
{
Assert.IsNotType<OkObjectResult>(successesResult);
}
}
[Fact]
public void GetSuccessesListFail_When_Page_Is_A_Negative()
{
_successService.Setup(x => x.GetSuccesses(1, 4, 0))
.Returns(new List<SuccessDto>());
var successesController =
new SuccessesController(_successService.Object, new NullLogger<SuccessesController>());
var successesResult = successesController.GetSuccesses(-1, 3, 0);
if (successesResult is StatusCodeResult statusCodeResult && statusCodeResult.StatusCode == 204) if (successesResult is StatusCodeResult statusCodeResult && statusCodeResult.StatusCode == 204)
{ {
@ -89,7 +106,7 @@ public class SuccessesUnitTest
} }
[Fact] [Fact]
public void GetSuccessInquiryIdFail() public void GetSuccessInquiryIdFail_When_Id_Not_Exist()
{ {
var successesList = GetSuccessesData(); var successesList = GetSuccessesData();
_successService.Setup(x => x.GetSuccessesByInquiryId(1)) _successService.Setup(x => x.GetSuccessesByInquiryId(1))
@ -108,6 +125,26 @@ public class SuccessesUnitTest
} }
} }
[Fact]
public void GetSuccessInquiryIdFail_When_Id_Negative()
{
var successesList = GetSuccessesData();
_successService.Setup(x => x.GetSuccessesByInquiryId(1))
.Returns(new List<SuccessDto> { successesList[0], successesList[1] });
var successesController =
new SuccessesController(_successService.Object, new NullLogger<SuccessesController>());
var sucessesResult = successesController.GetSuccessByInquiryId(-1);
if (sucessesResult is NotFoundObjectResult nfObjectResult)
{
var valeur = nfObjectResult.Value;
Assert.NotNull(valeur);
Assert.IsNotType<SuccessDto>(valeur);
Assert.DoesNotContain(valeur, successesList);
}
}
[Fact] [Fact]
public void GetSuccessUserIdSuccess() public void GetSuccessUserIdSuccess()
{ {
@ -140,7 +177,7 @@ public class SuccessesUnitTest
} }
[Fact] [Fact]
public void GetSuccessUserIdFail() public void GetSuccessUserIdFail_When_Id_Not_Found()
{ {
var successesList = GetSuccessesData(); var successesList = GetSuccessesData();
_successService.Setup(x => x.GetSuccessesByUserId(2)) _successService.Setup(x => x.GetSuccessesByUserId(2))
@ -159,6 +196,27 @@ public class SuccessesUnitTest
} }
} }
[Fact]
public void GetSuccessUserIdFail_When_Id_Negative()
{
var successesList = GetSuccessesData();
_successService.Setup(x => x.GetSuccessesByUserId(2))
.Returns(new List<SuccessDto> { successesList[2], successesList[3] });
var successesController =
new SuccessesController(_successService.Object, new NullLogger<SuccessesController>());
var sucessesResult = successesController.GetSuccessByUserId(-1);
if (sucessesResult is NotFoundObjectResult nfObjectResult)
{
var valeur = nfObjectResult.Value;
Assert.NotNull(valeur);
Assert.IsNotType<SuccessDto>(valeur);
Assert.DoesNotContain(valeur, successesList);
}
}
[Fact] [Fact]
public void DeleteSuccessSuccess() public void DeleteSuccessSuccess()
{ {
@ -177,7 +235,7 @@ public class SuccessesUnitTest
} }
[Fact] [Fact]
public void DeleteSuccessFail() public void DeleteSuccessFail_When_Not_Found()
{ {
_successService.Setup(x => x.DeleteSuccess(1, 1)) _successService.Setup(x => x.DeleteSuccess(1, 1))
.Returns(true); .Returns(true);
@ -192,6 +250,22 @@ public class SuccessesUnitTest
} }
} }
[Fact]
public void DeleteSuccessFail_When_Negative()
{
_successService.Setup(x => x.DeleteSuccess(1, 1))
.Returns(true);
var successesController =
new SuccessesController(_successService.Object, new NullLogger<SuccessesController>());
var sucessesResult = successesController.DeleteSuccess(-1, 278);
if (sucessesResult is NotFoundObjectResult nfObjectResult)
{
Assert.Null(nfObjectResult.Value);
Assert.IsNotType<bool>(nfObjectResult.Value);
}
}
[Fact] [Fact]
public void CreateSuccessSuccess() public void CreateSuccessSuccess()
{ {
@ -213,7 +287,7 @@ public class SuccessesUnitTest
} }
[Fact] [Fact]
public void CreateSuccessFail() public void CreateSuccessFail_When_Id_Not_Found()
{ {
_successService.Setup(x => x.CreateSuccess(8, 8, true)) _successService.Setup(x => x.CreateSuccess(8, 8, true))
.Returns(new SuccessDto(8, 8, true)); .Returns(new SuccessDto(8, 8, true));
@ -228,6 +302,22 @@ public class SuccessesUnitTest
} }
} }
[Fact]
public void CreateSuccessFail_When_Id_Negative()
{
_successService.Setup(x => x.CreateSuccess(8, 8, true))
.Returns(new SuccessDto(8, 8, true));
var successesController =
new SuccessesController(_successService.Object, new NullLogger<SuccessesController>());
var successesResult = successesController.CreateSuccess(new SuccessDto(-1, 818, true));
if (successesResult is BadRequestResult bdObjectResult)
{
Assert.Equal(400, bdObjectResult.StatusCode);
}
}
[Fact] [Fact]
public void UpdateSuccessSuccess() public void UpdateSuccessSuccess()
{ {
@ -249,7 +339,7 @@ public class SuccessesUnitTest
} }
[Fact] [Fact]
public void UpdateSuccessFail() public void UpdateSuccessFail_When_Ids_Are_Differents()
{ {
_successService.Setup(x => x.UpdateSuccess(1, 1, new SuccessDto(1, 2, true))) _successService.Setup(x => x.UpdateSuccess(1, 1, new SuccessDto(1, 2, true)))
.Returns(new SuccessDto(1, 2, true)); .Returns(new SuccessDto(1, 2, true));
@ -264,6 +354,40 @@ public class SuccessesUnitTest
} }
} }
[Fact]
public void UpdateSuccessFail_When_Id_Negative()
{
_successService.Setup(x => x.UpdateSuccess(1, 1, new SuccessDto(1, 2, true)))
.Returns(new SuccessDto(1, 2, true));
var successesController =
new SuccessesController(_successService.Object, new NullLogger<SuccessesController>());
var successesResult = successesController.UpdateSuccess(-2, 1, new SuccessDto(1, 2, true));
if (successesResult is BadRequestResult bdObjectResult)
{
Assert.Equal(400, bdObjectResult.StatusCode);
}
}
[Fact]
public void UpdateSuccessFail_When_Id_Not_Found()
{
_successService.Setup(x => x.UpdateSuccess(1, 1, new SuccessDto(1, 2, true)))
.Returns(new SuccessDto(1, 2, true));
var successesController =
new SuccessesController(_successService.Object, new NullLogger<SuccessesController>());
var successesResult = successesController.UpdateSuccess(1000, 1000, new SuccessDto(1000, 1000, true));
if (successesResult is BadRequestResult bdObjectResult)
{
Assert.Equal(400, bdObjectResult.StatusCode);
}
}
private List<SuccessDto> GetSuccessesData() private List<SuccessDto> GetSuccessesData()
{ {
List<SuccessDto> successesData = new List<SuccessDto>(4) List<SuccessDto> successesData = new List<SuccessDto>(4)

Loading…
Cancel
Save