Ajout + Traduction : Privacy Policy, Terms of Service, Our story. Modif footer : Ajout social media #3

Merged
clement.freville2 merged 2 commits from traduction into master 1 year ago
Owner

Il y a 3 nouvelles pages :

  • Privacy Policy
  • Terms of Service
  • Our story

Elles ont traduites en frnaçais et anglais

Ajout des icônes des réseaux sociaux avec liens lorsque l'on clique dessus

Il y a 3 nouvelles pages : - Privacy Policy - Terms of Service - Our story Elles ont traduites en frnaçais et anglais Ajout des icônes des réseaux sociaux avec liens lorsque l'on clique dessus
matis.mazingue added 1 commit 1 year ago
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
668372c4ac
Ajout + Traduction : Privacy Policy, Terms of Service, Our story.
clement.freville2 requested review from clement.freville2 1 year ago
matis.mazingue closed this pull request 1 year ago
matis.mazingue reopened this pull request 1 year ago
matis.mazingue changed title from Ajout + Traduction : Privacy Policy, Terms of Service, Our story. Modif footer : Ajout social media to WIP: Ajout + Traduction : Privacy Policy, Terms of Service, Our story. Modif footer : Ajout social media 1 year ago
matis.mazingue changed title from WIP: Ajout + Traduction : Privacy Policy, Terms of Service, Our story. Modif footer : Ajout social media to Ajout + Traduction : Privacy Policy, Terms of Service, Our story. Modif footer : Ajout social media 1 year ago
clement.freville2 requested changes 1 year ago
clement.freville2 left a comment
Owner

Please remove src/assets/img/tsetup-x64.4.14.4.exe and reduce the file size of the Instragram logo.

Please remove `src/assets/img/tsetup-x64.4.14.4.exe` and reduce the file size of the Instragram logo.
routerLinkActive="active"
[routerLinkActiveOptions]="{ exact: true }"
>{{ 'FooterPage.Contact' | translate}}</a>
<a routerLink="our_story" routerLinkActive="active" [routerLinkActiveOptions]="{ exact: true }">{{

URLs contain usually dashes.

-                 <a routerLink="our_story" routerLinkActive="active" [routerLinkActiveOptions]="{ exact: true }">{{ 
+                 <a routerLink="our-story" routerLinkActive="active" [routerLinkActiveOptions]="{ exact: true }">{{ 
URLs contain usually dashes. ```diff - <a routerLink="our_story" routerLinkActive="active" [routerLinkActiveOptions]="{ exact: true }">{{ + <a routerLink="our-story" routerLinkActive="active" [routerLinkActiveOptions]="{ exact: true }">{{ ```
routerLinkActive="active"
[routerLinkActiveOptions]="{ exact: true }"
>{{ 'FooterPage.Privacy' | translate}}</a>
<a routerLink="terms_of_service" routerLinkActive="active"

terms_of_service -> terms-of-service

`terms_of_service` -> `terms-of-service`
>{{ 'FooterPage.Privacy' | translate}}</a>
<a routerLink="terms_of_service" routerLinkActive="active"
[routerLinkActiveOptions]="{ exact: true }">{{ 'FooterPage.Terms' | translate}}</a>
<a routerLink="privacy_policy" routerLinkActive="active" [routerLinkActiveOptions]="{ exact: true }">{{

privacy_policy -> privacy-policy

`privacy_policy` -> `privacy-policy`
<div class="socials">
<!-- TODO - Add the socials icons-->
<div>{{ 'FooterPage.Social' | translate}}</div>
<!-- TODO - Add the socials icons-->
-         <!--        TODO - Add the socials icons--> 
```diff - <!-- TODO - Add the socials icons--> ```
sandkasten_logo!: string;
twitter_logo!: string;
instagram_logo!: string;
facebook_logo!: string;

You may assign them directly in the constructor.

  twitter_logo: string = 'assets/img/twitter.svg';
  instagram_logo: string = 'assets/img/instagram.svg';
  facebook_logo: string = 'assets/img/facebook.svg';
You may assign them directly in the constructor. ```ts twitter_logo: string = 'assets/img/twitter.svg'; instagram_logo: string = 'assets/img/instagram.svg'; facebook_logo: string = 'assets/img/facebook.svg'; ```
hugo!: string;
bastien!: string;
clement!: string;
matis!: string;

Same things about images here.

Same things about images here.
})
export class PrivacyPolicyComponent {
constructor(private router: Router) { }
ngOnInit(): void {

Remove this empty method.

Remove this empty method.
})
export class TermsOfServiceComponent {
constructor(private router: Router) { }
ngOnInit(): void {

No need to define this empty method, since your component doesn't implement any interface.

No need to define this empty method, since your component doesn't implement any interface.
},
"DataBreach": {
"Title": "Data breach",
"Text1": "In the event we become aware that the security of the Website and Services has been compromised or Users Personal Information has been disclosed to unrelated third parties as a result of external activity, including, but not limited to, security attacks or fraud, we reserve the right to take reasonably appropriate measures, including, but not limited to, investigation and reporting, as well as notification to and cooperation with law enforcement authorities. In the event of a data breach, we will make reasonable efforts to notify affected individuals if we believe that there is a reasonable risk of harm to the User as a result of the breach or if notice is otherwise required by law. When we do, we will send you an email."

Use the correct character ' instead of the unicode variation ().

Use the correct character `'` instead of the unicode variation (`’`).
matis.mazingue added 1 commit 1 year ago
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
02a6a5735a
Correction review traduction
matis.mazingue requested review from clement.freville2 1 year ago
clement.freville2 approved these changes 1 year ago
clement.freville2 merged commit 142819cccf into master 1 year ago
clement.freville2 deleted branch traduction 1 year ago

Reviewers

clement.freville2 approved these changes 1 year ago
continuous-integration/drone/push Build is passing
continuous-integration/drone/pr Build is passing
The pull request has been merged as 142819cccf.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sandkasten/sandkasten-web#3
Loading…
There is no content yet.