change-css

# Conflicts:
#	src/app/components/header/header.component.ts
#	src/app/components/landing-page/landing-page.component.ts
#	src/assets/i18n/en.json
#	src/assets/i18n/fr.json

clement.freville2 requested changes

src/app/components/header/header.component.ts Outdated

													
					    return this.translationService.getFlagImageUrl();

					  }

					export class HeaderComponent implements OnInit {

					    title!: string;

clement.freville2 commented

Owner

Init those fields in the constructor directly. This is a regression.

colin.frizot referenced this issue from a commit

Correct the regression from the pull request #5

colin.frizot added 1 commit

21b71ee473 Correct the regression from the pull request #5

clement.freville2 approved these changes

clement.freville2 merged commit a2f06ac993 into master 1 year ago

clement.freville2 referenced this issue from a commit

Enhance CSS (#5)

clement.freville2 deleted branch change-css

Reviewers

clement.freville2 approved these changes

continuous-integration/drone/push Build is passing

Details

continuous-integration/drone/pr Build is passing

Details

The pull request has been merged as a2f06ac993.

Sign in to join this conversation.

No Label

No Milestone

No project

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sandkasten/sandkasten-web#5

change-css #5

Reviewers