SonarQube code smells resolve #31
continuous-integration/drone/push Build is passing Details

LoginModification
Alexis 2 years ago
parent 3f7171c9ba
commit 0e43ca7f40

@ -44,7 +44,7 @@ class GatewayQuestion
)); ));
foreach ($question->getCategories()[$i] as $keyword){ foreach ($question->getCategories()[$i] as $keyword) {
$gatewayForm = new GatewayForm(); $gatewayForm = new GatewayForm();
$gatewayForm->assignKeywordToQuestion($keyword, $listPossibleResponse[$i], $idQuestion); $gatewayForm->assignKeywordToQuestion($keyword, $listPossibleResponse[$i], $idQuestion);
} }

@ -21,9 +21,9 @@ abstract class BoxQuestion extends Question
$this->possibleResponses = $possibleResponses; $this->possibleResponses = $possibleResponses;
} }
public abstract function responseStrategy(); abstract public function responseStrategy();
public abstract function printStrategy(): string; abstract public function printStrategy(): string;
/** /**
* @return array * @return array
@ -56,4 +56,4 @@ abstract class BoxQuestion extends Question
{ {
$this->categories = $categories; $this->categories = $categories;
} }
} }

@ -5,4 +5,4 @@ namespace BusinessClass;
interface IPrintQuestionStrategy interface IPrintQuestionStrategy
{ {
public function printStrategy(): string; public function printStrategy(): string;
} }

@ -5,4 +5,4 @@ namespace BusinessClass;
interface IResponseProcessingStrategy interface IResponseProcessingStrategy
{ {
public function responseStrategy(); public function responseStrategy();
} }

@ -17,9 +17,9 @@ abstract class Question implements IResponseProcessingStrategy, IPrintQuestionSt
$this->content = $content; $this->content = $content;
} }
public abstract function responseStrategy(); abstract public function responseStrategy();
public abstract function printStrategy(): string; abstract public function printStrategy(): string;
/** /**
* @return string * @return string

Loading…
Cancel
Save