SonarQube code smells resolve Num39
continuous-integration/drone/push Build is passing Details

LoginModification
Alexis 3 years ago
parent 6ef521d1c3
commit 2c423ce0ef

@ -8,7 +8,7 @@ abstract class Factory
{ {
abstract public function create(array $results): array; abstract public function create(array $results): array;
static public function getBuiltObjects(array $results, string $type): array public static function getBuiltObjects(array $results, string $type): array
{ {
$type = "\\Model\\Factory" . $type; $type = "\\Model\\Factory" . $type;
return (new $type())->create($results); return (new $type())->create($results);

@ -11,7 +11,7 @@ class FactoryQuestion extends Factory
{ {
$questions = []; $questions = [];
if ($results[0] != null) { if ($results[0] != null) {
for ($i = 0; $i < count($results[0]); $i++) { for ($i = 0; $i < count($results[0]); $i++) {
if (strcmp($results[0][$i]['type'], "BusinessClass\TextQuestion") == 0) { if (strcmp($results[0][$i]['type'], "BusinessClass\TextQuestion") == 0) {
$questions[] = new TextQuestion($results[0][$i]['content'], $results[0][$i]['id']); $questions[] = new TextQuestion($results[0][$i]['content'], $results[0][$i]['id']);
} else { } else {

@ -28,7 +28,7 @@ class ModelAdmin
$categories = $tmp; $categories = $tmp;
array_pop($categories); array_pop($categories);
if (strcmp($type,"BusinessClass\TextQuestion") == 0) { if (strcmp($type, "BusinessClass\TextQuestion") == 0) {
$question = new $type($questionContent, 0); $question = new $type($questionContent, 0);
} else { } else {
$question = new $type($responses, $questionContent, $categories, 0); $question = new $type($responses, $questionContent, $categories, 0);

Loading…
Cancel
Save