🚨 remove TODOs using comments and tickets instead
continuous-integration/drone/push Build is passing Details

pull/55/head
Alexis Drai 2 years ago
parent f947a4fea5
commit bcf7772e6d

@ -22,21 +22,22 @@ namespace Model
/// </summary> /// </summary>
public readonly Player player; public readonly Player player;
/* // ... faces
public IEnumerable<AbstractDieFace> Faces { get; private set; }
*/
/// <summary> /// <summary>
/// this private constructor is to be used only by factories /// this private constructor is to be used only by factories
/// </summary> /// </summary>
/// <param name="when">date and time of the turn</param> /// <param name="when">date and time of the turn</param>
/// <param name="player">player who played the turn</param> /// <param name="player">player who played the turn</param>
// TODO add faces
// ... faces
private Turn(DateTime when, Player player/*, IEnumerable<AbstractDieFace> faces*/) private Turn(DateTime when, Player player/*, IEnumerable<AbstractDieFace> faces*/)
{ {
this.when = when; this.when = when;
this.player = player; this.player = player;
/*Faces = faces;*/ // ... faces
} }
/// <summary> /// <summary>
@ -48,10 +49,12 @@ namespace Model
/// <param name="when">date and time of the turn</param> /// <param name="when">date and time of the turn</param>
/// <param name="player">player who played the turn</param> /// <param name="player">player who played the turn</param>
/// <returns>a new Turn object</returns> /// <returns>a new Turn object</returns>
// TODO add faces
// ... faces
public static Turn CreateWithSpecifiedTime(DateTime when, Player player/*, IEnumerable<AbstractDieFace> faces*/) public static Turn CreateWithSpecifiedTime(DateTime when, Player player/*, IEnumerable<AbstractDieFace> faces*/)
{ {
// TODO add validation for faces too
// ... faces
if (player == null) if (player == null)
{ {
throw new ArgumentNullException(nameof(player), "param should not be null"); throw new ArgumentNullException(nameof(player), "param should not be null");
@ -69,23 +72,21 @@ namespace Model
/// </summary> /// </summary>
/// <param name="player">player who played the turn</param> /// <param name="player">player who played the turn</param>
/// <returns>a new Turn object</returns> /// <returns>a new Turn object</returns>
// TODO add faces
// ... faces
public static Turn CreateWithDefaultTime(Player player/*, IEnumerable<AbstractDieFace> faces*/) public static Turn CreateWithDefaultTime(Player player/*, IEnumerable<AbstractDieFace> faces*/)
{ {
return CreateWithSpecifiedTime(DateTime.UtcNow, player/*, faces*/); return CreateWithSpecifiedTime(DateTime.UtcNow, player/*, faces*/);
} }
//TODO add faces // ... faces
/// <summary> /// <summary>
/// represents a turn in string format /// represents a turn in string format
/// </summary> /// </summary>
/// <returns>a turn in string format</returns> /// <returns>a turn in string format</returns>
public override string ToString() public override string ToString()
{ {
//string[] datetime = this.when.ToString("s", System.Globalization.CultureInfo.InvariantCulture).Split("T");
//string date = datetime[0];
//string time = datetime[1];
return String.Format("{0} -- {1} rolled {2}", return String.Format("{0} -- {1} rolled {2}",
ToStringIsoWithZ(), ToStringIsoWithZ(),
this.player.ToString(), this.player.ToString(),

Loading…
Cancel
Save