Alexis Drai
6f73dc5abf
🐛 Debug genericity
3 years ago
Alexis Drai
5937a1cc28
👔 ♻️ Fix #68
3 years ago
Alexis Drai
1403b5d7fb
🚧 WIP
3 years ago
Alexis Drai
a4f0b3948e
⚰️ Remove dead code (names for dice)
3 years ago
Alexis Drai
242cc86a79
🩹 fix #64
3 years ago
Alexis Drai
dcef907f24
🩹 fix #64
3 years ago
Alexis Drai
86ff2fe752
🔥 ⚰️ Fix #60
3 years ago
Alexis Drai
aaa94de362
🏗️ Fix #67
3 years ago
Ismail TAHA JANAN
5a76434f96
🎨 chanege Random type to static
3 years ago
Ismail TAHA JANAN
344a0fb9ac
🎨 improve code performance
3 years ago
Ismail TAHA JANAN
9292a2cc44
🩹 #59 : some name spaces
3 years ago
Ismail TAHA JANAN
8a81f2ddd7
🩹 #59 fix: add some name spaces
3 years ago
Ismail TAHA JANAN
da6babe2dd
#59 : � 🩹 fix: more conflict fixing
3 years ago
Ismail TAHA JANAN
ac4ebc71f0
conflict resolves
3 years ago
Ismail TAHA JANAN
306315c2ff
⚡ #59 feat:Die become abstract & add dice tipes as children
3 years ago
Alexis Drai
0f9f581603
⚗️ Add content to the stub to explore the logic of the app
3 years ago
Alexis Drai
15b7264fde
🚨 Fix code smells
3 years ago
Alexis Drai
48db9ba6de
💡 ♻️ Add to Game thanks to new classes, add fixes
3 years ago
Alexis Drai
d744b07e3b
♻️ Add FavGroup and refactor manager
3 years ago
Alexis Drai
10a48032bd
🏗️ Move Game into Games
3 years ago
Alexis Drai
92716d5f32
👔 Get started on the Game class
3 years ago
Alexis Drai
c7d3888a70
🐛 Change HashSet to List for ordering, add order
3 years ago
Alexis Drai
7e85dba135
🩹 Fix code smells
3 years ago
Alexis Drai
7389ee8756
✅ 💬 Include AbstractDieFace in Turn, update ToString(), pass tests
3 years ago
Alexis Drai
011db706e0
🏗️ 📦 ️ Make separate packages for clarity
3 years ago
Alexis Drai
f52676c901
🏗️ Add all (emptyish) classes, articulate
3 years ago
Alexis Drai
bcf7772e6d
🚨 remove TODOs using comments and tickets instead
3 years ago
Alexis Drai
8d8e55d348
🏗️ Add empty class
3 years ago
Alexis Drai
707a0a5ab2
✏️ Downgrade from TODO to memo
3 years ago
Alexis Drai
c88851af6e
✏️ Fix args, 🎨 improve code lisibility
3 years ago
Alexis Drai
21fec4a0d2
✨ Use abstraction, switch from uri to int
3 years ago
Alexis Drai
7c0c0d5fd9
✨ Use abstraction, switch from hexString to int
3 years ago
Alexis Drai
20b57ce31b
🚧 🧑💻 Put Value at abstract level, leave IDs for later
3 years ago
Alexis Drai
0e665493cf
✏️ ♻️ Rename abstract class
3 years ago
Ismail TAHA JANAN
c66aee78ea
feat #8 - create Stub
3 years ago
Alexis Drai
d734fd9215
✅ 👔 Add Turn class and first UTs
3 years ago
Alexis Drai
bbfe7291c4
🩹 Fix code smell
3 years ago
Alexis Drai
1ad5c7cf21
🛂 ✅ Add null checks and exceptions, reflect change in UTs
3 years ago
Alexis Drai
180c50b2c7
🩹 Improve exception-throwing
3 years ago
Alexis Drai
86597ef08f
🩹 Remove old or useless TODOs
3 years ago
Alexis Drai
fb02307b28
🩹 Move validation to constructor, clarify with comments
3 years ago
Alexis Drai
d36afce173
🐛 Add validation and delegation to Player.Remove()
3 years ago
Alexis Drai
fd00107e5f
🩹 Pass params by vals instead of by refs
...
if we pass parameters by reference, it must be because we want to
change them in the method and to keep those changes.
This seems like a different situation, so we should be able
to pass the objects by value.
3 years ago
Alexis Drai
9994798c6f
✅ Design unit tests for PlayerManager
3 years ago
Alexis Drai
33f390b074
✅ 👔 Trim player names and update tests
3 years ago
Alexis Drai
9e4b92f560
Remove redundant check to string value
3 years ago
Alexis Drai
ff6e634da1
🐛 Fix #47
3 years ago
Alexis Drai
676413959c
🚨 Fix #46
3 years ago
Alexis Drai
bfe20a653c
✅ Complete #27 and Fix #44
3 years ago
Alexis Drai
bd1502436d
🐛 Make hash case insensitive, check name validity
3 years ago