clean code smells 👮

Tests
Lucas Delanier 2 years ago
parent ef5c4f1eb1
commit 9a577959af

@ -1,7 +1,7 @@
import * as React from 'react'; import * as React from 'react';
import {TouchableOpacity, View, Text, StyleSheet, Image, ImageBackground, SafeAreaView} from 'react-native'; import {TouchableOpacity, View, Text, StyleSheet, Image, ImageBackground, SafeAreaView} from 'react-native';
import {RootStackScreenProps} from "../types"; import {RootStackScreenProps} from "../types";
import {useEffect, useRef, useState} from "react"; import {useEffect, useState} from "react";
import {useSafeAreaInsets} from "react-native-safe-area-context"; import {useSafeAreaInsets} from "react-native-safe-area-context";
import {addMovieToWatchLater, addMovieToFavourite, removeMovieTrending,} from "../redux/actions/actions"; import {addMovieToWatchLater, addMovieToFavourite, removeMovieTrending,} from "../redux/actions/actions";
import {useDispatch, useSelector} from 'react-redux'; import {useDispatch, useSelector} from 'react-redux';
@ -15,7 +15,7 @@ import {NewCard, SuggestedCard} from "../components/cards";
import {setFavouriteList,setWatchLaterList} from "../storage/storage" import {setFavouriteList,setWatchLaterList} from "../storage/storage"
export default function HomeScreen({navigation}: RootStackScreenProps<'Home'>) { export default function HomeScreen({}: RootStackScreenProps<'Home'>) {
// @ts-ignore // @ts-ignore
const trendingMovies = useSelector(state => state.appReducer.trendingMovies) const trendingMovies = useSelector(state => state.appReducer.trendingMovies)
// @ts-ignore // @ts-ignore
@ -30,7 +30,7 @@ export default function HomeScreen({navigation}: RootStackScreenProps<'Home'>) {
const [displayIndex, setdisplayIndex] = useState(0); const [displayIndex, setdisplayIndex] = useState(0);
const [suggestedMovies, setSuggestedMovies] = useState<number[]>([]) const [suggestedMovies, setSuggestedMovies] = useState<number[]>([])
var swiper: any = null let swiper: any = null
const insets = useSafeAreaInsets() const insets = useSafeAreaInsets()
@ -136,7 +136,7 @@ export default function HomeScreen({navigation}: RootStackScreenProps<'Home'>) {
useEffect(() => { useEffect(() => {
const interval = setInterval(() => { setInterval(() => {
const today = moment() const today = moment()
today.set({hour: 0, minute: 0, second: 0, millisecond: 0}) today.set({hour: 0, minute: 0, second: 0, millisecond: 0})
@ -185,7 +185,6 @@ export default function HomeScreen({navigation}: RootStackScreenProps<'Home'>) {
dispatch(addMovieToWatchLater(props)) dispatch(addMovieToWatchLater(props))
dispatch(removeMovieTrending(props)) dispatch(removeMovieTrending(props))
setWatchLaterList(newWatchLaterMovies) setWatchLaterList(newWatchLaterMovies)
console.log("movie: ", props.id, props.full_date, new Date(props.full_date).getTime()), new Date(trendingMovies[displayIndex].full_date).getTime()
if (displayIndex == trendingMovies.length - 1) { if (displayIndex == trendingMovies.length - 1) {
setdisplayIndex(0) setdisplayIndex(0)
swiper.swipeLeft() swiper.swipeLeft()
@ -202,9 +201,7 @@ export default function HomeScreen({navigation}: RootStackScreenProps<'Home'>) {
else{ else{
dispatch(addMovieToFavourite(props)) dispatch(addMovieToFavourite(props))
dispatch(removeMovieTrending(props)) dispatch(removeMovieTrending(props))
console.log(favouriteMovies)
setFavouriteList(newFavouriteMovies) setFavouriteList(newFavouriteMovies)
console.log("movie: ", props.id, props.full_date, new Date(props.full_date).getTime()), new Date(trendingMovies[displayIndex].full_date).getTime()
if (displayIndex == trendingMovies.length - 1) { if (displayIndex == trendingMovies.length - 1) {
setdisplayIndex(0) setdisplayIndex(0)
swiper.swipeLeft() swiper.swipeLeft()

@ -1,5 +1,5 @@
import * as React from 'react'; import * as React from 'react';
import {TouchableOpacity, ScrollView, View, Text, StyleSheet, Image, SafeAreaView, FlatList, Animated} from 'react-native'; import {TouchableOpacity, ScrollView, View, Text, StyleSheet, Image, SafeAreaView, FlatList} from 'react-native';
import {RootStackScreenProps} from "../types"; import {RootStackScreenProps} from "../types";
import {useSafeAreaInsets} from "react-native-safe-area-context"; import {useSafeAreaInsets} from "react-native-safe-area-context";
import Movie from "../model/Movie"; import Movie from "../model/Movie";
@ -11,7 +11,6 @@ import Ionicons from "@expo/vector-icons/Ionicons";
import MinimalMovie from "../model/MinimalMovie"; import MinimalMovie from "../model/MinimalMovie";
import Review from "../model/review"; import Review from "../model/review";
import Stars from "../components/StarsComponent"; import Stars from "../components/StarsComponent";
import minimalMovie from "../model/MinimalMovie";
import {formatTime} from "../model/formatTime"; import {formatTime} from "../model/formatTime";
export default function InfoScreen({navigation, route}: RootStackScreenProps<'Info'>) { export default function InfoScreen({navigation, route}: RootStackScreenProps<'Info'>) {
@ -80,7 +79,7 @@ export default function InfoScreen({navigation, route}: RootStackScreenProps<'In
} }
type SimilarMovieProps = { type SimilarMovieProps = {
movie: minimalMovie; movie: MinimalMovie;
}; };
function SimilarMovie(props: SimilarMovieProps) { function SimilarMovie(props: SimilarMovieProps) {
@ -341,7 +340,6 @@ export default function InfoScreen({navigation, route}: RootStackScreenProps<'In
const creditResponse = (await fetch(config.base_url + "movie/" + item.id + "/credits?api_key=" + config.api_key + "&language=fr-FR")); const creditResponse = (await fetch(config.base_url + "movie/" + item.id + "/credits?api_key=" + config.api_key + "&language=fr-FR"));
const creditJson = await creditResponse.json(); const creditJson = await creditResponse.json();
//console.log("credittttttt", creditJson)
// @ts-ignore // @ts-ignore
let creditList = creditJson.cast.map((elt) => { let creditList = creditJson.cast.map((elt) => {
if (elt["popularity"]) if (elt["popularity"])
@ -349,7 +347,6 @@ export default function InfoScreen({navigation, route}: RootStackScreenProps<'In
}); });
creditList = creditList.slice(0, 5).sort((a: [fullname: string, profile_path: string, popularity: number], b: [fullname: string, profil_path: string, popularity: number]) => b[2] - a[2]); creditList = creditList.slice(0, 5).sort((a: [fullname: string, profile_path: string, popularity: number], b: [fullname: string, profil_path: string, popularity: number]) => b[2] - a[2]);
//console.log("credit", creditList);
setCredit(creditList); setCredit(creditList);
} }
const getSimilarMovies = async () => { const getSimilarMovies = async () => {
@ -360,7 +357,6 @@ export default function InfoScreen({navigation, route}: RootStackScreenProps<'In
const SimilarMoviesList = SimilarMoviesJson.results.slice(0, 10).map((elt) => { const SimilarMoviesList = SimilarMoviesJson.results.slice(0, 10).map((elt) => {
return new MinimalMovie(elt["original_title"], elt["poster_path"]) return new MinimalMovie(elt["original_title"], elt["poster_path"])
}); });
//console.log("similar", SimilarMoviesList);
setSimilarMovies(SimilarMoviesList); setSimilarMovies(SimilarMoviesList);
} }
const getReview = async () => { const getReview = async () => {
@ -375,8 +371,6 @@ export default function InfoScreen({navigation, route}: RootStackScreenProps<'In
ReviewList = ReviewList.filter((review: Review, index: number, array: Review[]) => { ReviewList = ReviewList.filter((review: Review, index: number, array: Review[]) => {
return array.findIndex((item: Review) => item.pseudo === review.pseudo) === index; return array.findIndex((item: Review) => item.pseudo === review.pseudo) === index;
}); });
//console.log("review", ReviewJson.results);
setReview(ReviewList); setReview(ReviewList);
} }

Loading…
Cancel
Save