perf : suppression d'une méthode inutilisée

API
Damien NORTIER 1 year ago
parent f7a8ace007
commit 508e43fb35

@ -48,11 +48,6 @@ namespace DataManagers
return await Task.FromResult<(int nbPages, IEnumerable<Answer>? answers)>((res.nbPages, tmp)); return await Task.FromResult<(int nbPages, IEnumerable<Answer>? answers)>((res.nbPages, tmp));
} }
public async Task<IEnumerable<Answer>?> getAnswers(string content)
{
return (await manager.getAnswers(content))?.Select(a => a.ToModel());
}
public async Task<IEnumerable<Answer>?> getAnswersByIdQuestion(int id) public async Task<IEnumerable<Answer>?> getAnswersByIdQuestion(int id)
{ {
var tmp = await manager.getAnswersByIdQuestion(id); var tmp = await manager.getAnswersByIdQuestion(id);

@ -30,7 +30,7 @@ namespace EntityManagers
} }
await dbContext.Answers.AddAsync(new AnswerEntity { Content = answer.Content.ToLower(), IdQuestion = answer.IdQuestion }); await dbContext.Answers.AddAsync(new AnswerEntity { Content = answer.Content.ToLower(), IdQuestion = answer.IdQuestion });
await dbContext.SaveChangesAsync(); await dbContext.SaveChangesAsync();
return await dbContext.Answers.Where(a => a.Content == answer.Content && a.IdQuestion == answer.IdQuestion).FirstAsync(); return await dbContext.Answers.Where(a => a.Content == answer.Content.ToLower() && a.IdQuestion == answer.IdQuestion).FirstAsync();
} }
public async Task<AnswerEntity?> getAnswer(int id) public async Task<AnswerEntity?> getAnswer(int id)
@ -38,15 +38,10 @@ namespace EntityManagers
return await dbContext.Answers.Where(a => a.Id == id).FirstOrDefaultAsync(); return await dbContext.Answers.Where(a => a.Id == id).FirstOrDefaultAsync();
} }
public async Task<IEnumerable<AnswerEntity>?> getAnswers(string content)
{
return await Task.FromResult<IEnumerable<AnswerEntity>?>(dbContext.Answers.Where(a => a.Content == content));
}
public async Task<(int nbPages, IEnumerable<AnswerEntity>? answers)> getAnswers(int page, int count, AnswerOrderCriteria orderCriteria = AnswerOrderCriteria.ById) public async Task<(int nbPages, IEnumerable<AnswerEntity>? answers)> getAnswers(int page, int count, AnswerOrderCriteria orderCriteria = AnswerOrderCriteria.ById)
{ {
int nbEl = getNbAnswers(); int nbEl = getNbAnswers();
if (page < 0 || count < 0 || page > nbEl / count) if (page <= 0 || count <= 0 || page > nbEl / count)
{ {
return await Task.FromResult<( return await Task.FromResult<(
int nbPages, int nbPages,
@ -112,7 +107,7 @@ namespace EntityManagers
public async Task<AnswerEntity?> updateAnswer(int id, AnswerEntity answer) public async Task<AnswerEntity?> updateAnswer(int id, AnswerEntity answer)
{ {
var tmp = await dbContext.Answers.Where(a => a.Id == id).FirstOrDefaultAsync(); var tmp = await getAnswer(id);
if(tmp == null) if(tmp == null)
{ {
return null; return null;

@ -81,14 +81,5 @@ namespace ManagerInterfaces
/// to the id or null if there isn't any /// to the id or null if there isn't any
/// </returns> /// </returns>
public Task<T?> getAnswer(int id); public Task<T?> getAnswer(int id);
/// <summary>
/// get answers
/// </summary>
/// <param name="content">the content of the answer</param>
/// <returns>
/// the answer that corresponde
/// to the content or null if there isn't any
/// </returns>
public Task<IEnumerable<T>?> getAnswers(string content);
} }
} }

@ -78,10 +78,5 @@ namespace ServiceManagers
{ {
return (await manager.updateAnswer(id, answerdto.ToModel()))?.ToDto(); return (await manager.updateAnswer(id, answerdto.ToModel()))?.ToDto();
} }
public async Task<IEnumerable<AnswerDto>?> getAnswers(string content)
{
return (await manager.getAnswers(content))?.Select(a => a.ToDto());
}
} }
} }

@ -92,11 +92,6 @@ namespace WebApi
return AnswerManager.getAnswers(nb, count, orderCriteria); return AnswerManager.getAnswers(nb, count, orderCriteria);
} }
public Task<IEnumerable<AnswerDto>?> getAnswers(string content)
{
return AnswerManager.getAnswers(content);
}
public Task<IEnumerable<AnswerDto>?> getAnswersByIdQuestion(int id) public Task<IEnumerable<AnswerDto>?> getAnswersByIdQuestion(int id)
{ {
return AnswerManager.getAnswersByIdQuestion(id); return AnswerManager.getAnswersByIdQuestion(id);

Loading…
Cancel
Save